Repository navigation
fix(cargo): quote CC and LIBRARY_PATH in the EESSI prelude - #31
Merged
Merged
Conversation
The rebased #31, "fix(cargo): quote CC and LIBRARY_PATH in the EESSI prelude", on main.
HaoZeke
force-pushed
the
fix/cargo-prelude-quoting
branch
from
November 16, 2026 07:13
9ad96aa to
ab64bfa
Compare
HaoZeke
added a commit
that referenced
this pull request
Nov 16, 2026
The rebased #34, "feat(target): run the EESSI target through eb-local", on top of #31. The Cargo prelude in src/cargo.rs keeps both: #31's CC default, quoted LINKER, filtered triple and quoted eval, inside #34's chained triple read (`_triple= && if ...; fi &&`). The inline comment that cited scripts/eessi-extend-eb.sh goes, as in #34, which deletes that script and moves the best-effort note to the function's doc comment.
HaoZeke
added a commit
that referenced
this pull request
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cargo-on-EESSI prelude quotes
CCandLIBRARY_PATH.LINKER=${CC:-gcc}and anevalofCARGO_TARGET_*_LINKER=${CC:-gcc}reparsed the value, so aCCthat held more than a linker was run.LIBRARY_PATHwas expanded the same way. The prelude now defaults an emptyCCtogcc, exportsLINKER="$CC", restricts the target triple to a variable name, and walksLIBRARY_PATHas data. The howto and CLI reference match that.eessi_cargo_isolation_does_not_run_a_command_hidden_in_ccruns the prelude with aCCthat would print a marker if it were executed, and checks the marker is absent. The pypi/CRAN extend fixture checks the quoted form. The commit has a towncrier fragment.